-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing static API #107
Removing static API #107
Conversation
@abatishchev I noticed you removed these files:
These tests aren't duplicated anywhere else. I think maybe we should change them to using the instance (not static), instead of deleting them? |
So did I :-D Never mind, closed that PR in favor of this one. Regarding the tests. IIRC, new tests are just clones of old tests except the part where static factory is assigned to substitute JSON (de)serializer. So we should be fine by deleting them. An additional review by separate pair of eyes would be helpful though! |
Oops, closed wrong one. Reopened. |
Re: tests - I agree that the duplicate tests in |
Frankly I don't. This functionality goes away with the removal of static API. |
Ah, now I'm understanding you. Yep! Let's merge. |
Pushed to NuGet as 3.0.0-beta3. @nbarbettini Thanks for your help! As always :) |
Rebased #103